Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Create 1.1.1.1.xml - #15077

Closed
ghost wants to merge 4 commits into
masterfrom
unknown repository
Closed

ghost wants to merge 4 commits into
masterfrom
unknown repository

Conversation

@ghost

@ghost ghost commented Apr 5, 2018

Copy link
Copy Markdown

Supersedes #15064.

@jeremyn

jeremyn commented Apr 5, 2018

Copy link
Copy Markdown
Contributor

Thanks for your pull request, however it is not appropriate to try to supersede another contributor's recent, open PR, so I'm closing this. If you want to modify #15064 then please make a note there, or else wait for it to be merged and then make another PR.

@jeremyn jeremyn closed this Apr 5, 2018
@ghost

ghost commented Apr 5, 2018

Copy link
Copy Markdown
Author

@jeremyn You could have let me remove the "supersedes" message. I will be contacting the EFF about this PR.

@ghost
ghost deleted the patch-3 branch April 5, 2018 17:58
@jeremyn

jeremyn commented Apr 5, 2018

Copy link
Copy Markdown
Contributor

Regardless of whether you said it supersedes it or not, it does actually conflict with it, and preference should be given to the PR that was submitted first.

In any case you are, as I said, welcome to add suggestions to the other PR, or wait for it to be merged and then make a new PR.

@ghost

ghost commented Apr 6, 2018

Copy link
Copy Markdown
Author

@jeremyn No, preference should be given to a superior PR. Anyway, I'm contacting the EFF about this PR's closure.

@ghost

ghost commented Apr 6, 2018

Copy link
Copy Markdown
Author

@jeremyn

jeremyn commented Apr 7, 2018

Copy link
Copy Markdown
Contributor

@epicminecrafting You are welcome to contact the EFF privately if you want.

This is generally not the sort of project where people are expected to be competitive about PRs, or where maintainers are interested in judging whether one PR is superior to another by some measure. We encourage contributors to collaborate with each other to improve the extension.

@Hainish Could you please make some comment here?

@Hainish

Hainish commented Apr 7, 2018

Copy link
Copy Markdown
Member

@epicminecrafting I think it's appropriate in this case to either

  1. Wait for the previous PR to be merged, then open a subsequent PR to amend it, or
  2. Add a comment in that PR to point out the perceived limitations or suggest improvements

We like to encourage a collaborative environment between contributors. Thanks for your contribution.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants